openreview/openreview-web

Consoles: Extract console tabs into components

Opened this issue · 2 comments

enrubio commented

This will help with testing the tabs. Mentioned here: #2025 (comment)

xkopenreview commented

@enrubio if you don't have time i can work on this

  • 👍1
xkopenreview commented

looks like current handling of AC console for the case of no tab # in url is wrong (although it's working)
the active attribute of the assigned submissions tab is not set correctly
because
default tab id is using ${pluralizeString(submissionName) which usually has first letter capitalized
while activate attribute is comparing it with pluralizeString(submissionName).toLowerCase()

it appears to be working because the condition to render tab content is checking submissionName.toLowerCase()

will be corrected in the console tabs pr