Minified file is missing version
adgoncal opened this issue · 5 comments
a.version={versionStr:"<%= osdVersion.versionStr %>",major:parseInt("<%= osdVersion.major %>",10),minor:parseInt("<%= osdVersion.minor %>",10),revision:parseInt("<%= osdVersion.revision %>",10)It is missing version in 2.2.0 also.
2.1.0 is fine.
@adgoncal Good catch!
Looks like it happened here, since we're no longer uglifying the concatted version (which is where the process flag fills in the grunt template bits).
openseadragon/openseadragon@4434361
That's part of openseadragon/openseadragon#831 by @avandecreme. In the discussion there, it sounds like it would be fine to go back to using the concatted version instead of the original sources. I took a look at https://github.com/gruntjs/grunt-contrib-uglify and it doesn't seem to have a process feature.
@avandecreme What do you think?
Ha yes sorry for having broken that. It was already reported in openseadragon/openseadragon#1024
I will make sure to fix that for the next release.
@avandecreme Excellent, thank you!