openservicebrokerapi/osb-checker

Error in test.js

jhiemer opened this issue · 6 comments

Hi,
please excuse, the perhaps stupid question, but isn't that wrong:

https://github.com/openservicebrokerapi/osb-checker/blob/master/2.13/tests/test/test.js#L379

Why is this below bindings and not in provisions?

Hi @duglin @mattmcneeney , please assign it to me if nobody is willing to solve this problem, thanks!

Those tests seem to be related to deprovisioning. Sorry if this is a stupid question, but I'm not sure what the problem is here?

Hi @mattmcneeney , IMO technically it works fine, but what confuses people is why we pass some configuration data of binding into deprovision test case. What do you think?

Ah I see, thanks. Yeah that is strange - especially because it's not even testing anything to do with bindings (it's not even testing the "Deleting a service instance that has a service binding" scenario). Can we just remove the bits to do with bindings? The actual test cases seem related to deprovisioning only.

Can you take a look at this PR #41 ? It's one proposed solution from my side.