Incorrect query string in async deprovision test
stefan-sto opened this issue · 4 comments
It looks like the query string in async deprovsion test is incorrect (two question marks):
/v2/service_instances/8f020c46-c74e-54d5-f3a6-c8c25f422d6c?plan_id=0f4008b5-XXXX-XXXX-XXXX-dace631cd648&service_id=acb56d7c-XXXX-XXXX-XXXX-feb140a59a66?accepts_incomplete=false
I think that the line should be changed to use '&' instead of '?':
.delete(handler + '&accepts_incomplete=false')
Also it seems like the code that invokes .send() is not needed as the service_id and the plan_id are part of the query string.
Hi @stefan-sto , good catch. I think the main issue is in testAsyncParameter method, and because the handler is /v2/service_instances/' + instanceId + '?plan_id=' + queryStrings.plan_id + '&service_id=' + queryStrings.service_id, so line 627 should be changed. Is that what you think?
BTW, would you like to pull a PR to solve it, or I can do that for you : )
Hi @leonwanghui . I think changing the '?' to '&' on line 627 would be the easiest solution (it is also possible to use the .query method but this would require some refactoring of the code).
Could you make this PR, please? I saw that it is required to sign a CLA so we may discuss in our organization to have a corporate agreement, but it will take some time.
Thanks, Stefan
@stefan-sto Sure, my glad : )