openshift-eng/elliott

Python 3 support

Closed this issue · 2 comments

yazug commented

In starting to look at elliott I noticed a number of possible issues with python3 support in the code base. Below are a few that I saw so far.

  • tox missing py3 target (available in the python-3 branch)
  • setup.py is missing test deps
  • print() issue
  • urlparse error
  • unicode
  • absolute vs relative imports
  • iteritems
  • dict values() is view not a list in python3
  • contextlib.next was replace by ExitStack (in a unittest)
  • unittests and elliottlib.assertions.FileNotFoundError and ChildProcessError are not working in py3

I did see pull request #82 started looking at this

yazug commented

Looks like there is topic branch of python-3 with some work

Fixed by #85 and #104.