openshift/assisted-service

Incorrect conversion to Gigabytes

nsatsia opened this issue · 6 comments

nsatsia commented 
sizeGB := int(disk.SizeBytes / (1024 * 3))

Should be

sizeGB := int(disk.SizeBytes / Pow(1024, 3))

In the following code:

assisted-service/internal/controller/controllers/bmh_agent_controller.go

Line 912 in 29236b3

sizeGB := int(disk.SizeBytes / (1024 * 3))

openshift-bot commented

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

nsatsia commented

/remove-lifecycle stale

mkowalski commented

Thanks for pointing out this issue! It gets fixed by #4205

openshift-bot commented

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

mkowalski commented

/close

openshift-ci commented

@mkowalski: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.