openshift/builder

Support for private submodules with different secrets

Closed this issue · 5 comments

max3903 commented

Hello,

I am trying to build a Dockerfile app from a Github private repo which includes various git-submodules and some are private.

My .gitmodules:

[submodule "sub-repo"]
	path = src/sub-repo
	url = ssh://git@github.com/myorg/sub-repo.git
	branch = master

I created 2 secrets:

kind: Secret
apiVersion: v1
metadata:
  name: github-main-repo
  namespace: myapp
  selfLink: /api/v1/namespaces/myapp/secrets/github-main-repo
  annotations:
    build.openshift.io/source-secret-match-uri-1: 'ssh://git@github.com/myorg/main-repo*'
type: kubernetes.io/ssh-auth

kind: Secret
apiVersion: v1
metadata:
  name: github-sub-repo
  namespace: myapp
  selfLink: /api/v1/namespaces/myapp/secrets/github-sub-repo
  annotations:
    build.openshift.io/source-secret-match-uri-1: 'ssh://git@github.com/myorg/sub-repo*'
type: kubernetes.io/ssh-auth

linked them to the builder and added them to my build config:

    sourceSecret:
      name: github-main-repo
    secrets:
      - secret:
          name: github-main-repo
      - secret:
          name: github-sub-repo

I can clone the main repo with the secret in sourceSecret but it then fails at cloning the submodule.

Is it a supported scenario? Is it something that could be supported? Otherwise what are my options?

max3903 commented

Github does not support adding the same public key to 2 repositories.

openshift-bot commented

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot commented

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot commented

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.