openshift/cloud-credential-operator

Security Risk - Cloud Credential Operator Needs Credential Ephemeral or Automatically Rotate

Closed this issue · 4 comments

Description of Problem

cloud-credential-operator doesn't allow a credential to be ephemeral or to be automatically rotated. This raised a serious security concern and needs to be addressed as soon as possible. Please see the code: https://github.com/openshift/cloud-credential-operator/blob/master/pkg/aws/client.go#L105 on client.go. line 105-106.

The code doesn't allow a credential to be ephemeral or to be automatically rotated. For other integrations they have with AWS it sounds like security requires them to use temporary tokens, which the cloud credential operator doesn't allow.

Currently, the testing platform is AWS, but this needs to addressed for Bare-Metal (on-prem) and other platforms.

OCP version

  • 4.2
  • 4.1
  • 3.11

Hosted Cloud

  • AWS
  • Bare Metal
  • Azure
  • GCP
  • VMWare

Expected behavior

Cloud Credential Operator should make the credential automatically rotated or be ephemeral.

Severity

Critical. This is a security concern.

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.