openshift/ingress-node-firewall

Incorrect spec.interface name defined causes daemon to stop applying additional INF policies

Closed this issue · 1 comments

Describe the bug
Creating an INF with a spec.interface name that is not found on the target node causes subsequent INF policies not to be applied.

To Reproduce
Steps to reproduce the behaviour:

  1. Create INF with interface name that doesnt exist
  2. Create another INF policy that is valid

Expected behaviour
I expected the INF policy with a bad interface name not to block subsequent INF policies application

Screenshots
NA

Desktop (please complete the following information):
All

This issue is to discuss if this is expected behaviour.

Reconciler error	{"controller": "ingressnodefirewallnodestate", "controllerGroup": "ingressnodefirewall.openshift.io", "controllerKind": "IngressNodeFirewallNodeState", "IngressNodeFirewallNodeState": {"name":"worker-2.ostest.test.metalkube.org","namespace":"openshift-ingress-node-firewall"}, "namespace": "openshift-ingress-node-firewall", "name": "worker-2.ostest.test.metalkube.org", "reconcileID": "c205ded1-5363-48a7-a493-7f9891af97f0", "error": "FailedToSyncIngressNodeFirewallResources: Fail to attach ingress node Firewall rules: invalid interface eth0", "errorVerbose": "Fail to attach ingress node Firewall rules: invalid interface eth0\nFailedToSyncIngressNodeFirewallResources\ngithub.com/openshift/ingress-node-firewall/controllers.(*IngressNodeFirewallNodeStateReconciler).reconcileResource\n\t/go/src/github.com/openshift/ingress-node-firewall/controllers/ingressnodefirewallnodestate_controller.go:95\ngithub.com/openshift/ingress-node-firewall/controllers.(*IngressNodeFirewallNodeStateReconciler).Reconcile\n\t/go/src/github.com/openshift/ingress-node-firewall/controllers/ingressnodefirewallnodestate_controller.go:77\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/go/src/github.com/openshift/ingress-node-firewall/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:121\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/src/github.com/openshift/ingress-node-firewall/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:320\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/src/github.com/openshift/ingress-node-firewall/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:273\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/src/github.com/openshift/ingress-node-firewall/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:234\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1571"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler