openshift/jenkins

Support for websocket connection

Closed this issue · 4 comments

See https://github.com/jenkinsci/jep/blob/master/jep/222/README.adoc

Around Jan 2020 Jenkins has added support for WebSocket connection from inbound agents.

This greatly simplifies the setup of Jenkins on OpenShift when slave pods needs to be spawn up in different namespace or even different cluster.

Without this, the Jenkins master deployment would require nodePort to be configured so that the slaves can communicate with the master using Jenkins tunnel.

This change in Kubernetes plugin added the "WebSocket" option
image
and sets the JENKINS_WEB_SOCKET environment variable when the cluster is configured with it. However the slaves provided by OpenShift does not honor this.

Please consider adding the following code to slave-base/contrib/bin/run-jnlp-client to support websocket connection:

  if [[ "$@" != *"-webSocket"* ]]; then
    if [ "$JENKINS_WEB_SOCKET" = true ]; then
      PARAMS="$PARAMS -webSocket"
    fi
  fi

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

akram commented

/remove-lifecycle rotten

akram commented

Fixed by #1312
/close