openshift/oadp-operator

Configure liveness, readiness and startup probes for sample applications

mateusoliveira43 opened this issue · 6 comments

Remove arbitrary waits from E2E code, by configuring liveness, readiness and startup probes for sample applications.

Example of arbitrary wait:

// TODO this should be a function, not an arbitrary sleep
log.Printf("Sleeping for %v to allow application to be ready for case %s", brCase.AppReadyDelay, brCase.Name)
time.Sleep(brCase.AppReadyDelay)

Reference: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/

after adding it through #1277, the hardcoded wait is still needed

still need to study more on how to remove arbitrary waits from E2E code

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

/remove-lifecycle stale

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

/lifecycle frozen

Closing this because the only 2 sleeps currently in code have message explaining why they are needed