openshift/openshift-origin-design

Clarify whether and when to hide/disable action menu items

Closed this issue · 6 comments

If an action is normally available for a particular resource (e.g. Start Maintenance on a node) but for whatever reason that action isn't recommended (maybe the node is a master and doing that would be a very bad idea) I believe our current convention is to hide that action menu item entirely.

If that's the case, we should update our Action Menu convention to mention that.

Are there examples where we don't do this? Maybe we should discuss whether we should/shouldn't adopt alternative approaches like showing the action as disabled, maybe with tooltip text on hover (eh) or a variation of whatever modal/form that usually appears but with the primary button disabled and an explanation of why the action isn't allowed or encouraged.

Sounds like OpenShift Virtualization now displays descriptive text underneath disabled action menu items (Delete template). @matthewcarleton could you provide a screenshot/mockup of what was implemented here for reference?

Also a question as to whether Disable is somewhat destructive and we should consider updating the convention around where that's placed. FYI @itsptk

Here's an example of how we're doing it in 4.7
Screen Shot 2021-01-21 at 2 59 53 PM

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.