openshift/sriov-network-operator

Worker="" vs Worker="foo"

ns-rlewkowicz opened this issue · 6 comments

ns-rlewkowicz commented

Our worker nodes are tagged with node-role.kubernetes.io/worker: "true" and I believe with how this is written, that matters.

"node-role.kubernetes.io/worker": "",

Looks like there's a config option I'll take a closer look at. Ideally it would just check for the presence of the label, not the value.

ns-rlewkowicz commented

That worked

apiVersion: sriovnetwork.openshift.io/v1
kind: SriovOperatorConfig
metadata:
  annotations:
  name: default
  namespace: sriov-network-operator
spec:
  configDaemonNodeSelector:
    node-role.kubernetes.io/worker": "true"
  enableInjector: true
  enableOperatorWebhook: false
  logLevel: 2

But now I have issues with the other DS. Node selectors work on a fresh minikube install, but this is troublesome to incorporate into an existing environment.

I need more control for node selectors globally

ns-rlewkowicz commented

Overall this is fairly painful to use outside of a dev environment. It aggressively reconciles everything but does so with a VERY limited configuration set reasonably exposed.

zeeke commented

Hi @ns-rlewkowicz! This repository is for openshift changes only.
Please, open an issue on the upstream repo https://github.com/k8snetworkplumbingwg/sriov-network-operator and discuss the issue with the rest of the community.

openshift-bot commented

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

SchSeba commented

lets continue to work on this in the u/s repo https://github.com/k8snetworkplumbingwg/sriov-network-operator

/close

openshift-ci commented

@SchSeba: Closing this issue.

In response to this:

lets continue to work on this in the u/s repo https://github.com/k8snetworkplumbingwg/sriov-network-operator

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.