change name `mapping` to `model` or `cube`

Question

change name `mapping` to `model` or `cube`

Closed this issue 9 years ago · 3 comments

pwalsh commented 9 years ago

Probably model : I believe it is much closer to what we now have than mapping.

Raised in #93 (comment)

Also https://github.com/dataprotocols/dataprotocols/issues/238

pudo commented 9 years ago

+1

Answer 1 · 2016-01-04T20:52:44.000Z

I'm generally in favor of this as "mapping" is probably insufficient for describing what is happening in the mapping object. Beyond mapping physical ("source") columns to logical columns, the object describes how they relate to each other ("measures" v.s. "dimensions"). The fact that this object also gives fiscal types to dimensions makes me prefer the more generic model over cube.

Answer 2 · 2016-01-15T11:29:44.000Z

AGREED. Rename mapping to model.