openstreetmap/chef

Broken urls on the OWG website feed

gravitystorm opened this issue · 1 comments

gravitystorm commented

There's lots of broken urls in the atom feed for the operations website - most of the urls have an extraneous leading slash.

This is due to incorrectly passing a full url to --baseurl when building:

chef/cookbooks/foundation/recipes/owg.rb

Line 72 in aeaa46f

command "bundle exec jekyll build --trace --baseurl=https://operations.osmfoundation.org"

https://byparker.com/blog/2014/clearing-up-confusion-around-baseurl/

--baseurl is only used for subpaths. By passing a fully qualified url, we're confusing the jekyll url filters which are then adding the extra leading slash.

We don't notice it on the rest of the site, since we use interpolation rather than filters, e.g. <a href="{{ site.baseurl }}/reports/">Reports</a> instead of <a href="{{ "/reports/" | absolute_url }}>Reports</a> - which would highlighted the problem much earlier.

I think the solution is to:

  • Set site.url in the owg-website configuration. This will be overridden during development mode to be localhost anyway.
  • Remove the --baseurl switch when building
    I think both changes will need to be coordinated, since having a url setting and a baseurl setting both active at the same time will cause some chaos!