openstyles/stylus

[Request] Use "Back to style manager" as a button label instead of "↩"

xnuk opened this issue · 3 comments

xnuk commented

Current

Button named "↩" has a tooltip: "Back to style manager"

stylus/edit.html

Line 401 in c1604ba

<button id="cancel-button" i18n="title:styleCancelEditLabel">↩</button>

Why

I often find myself struggling to go "Manage" page from the editor. This button does that, but every time I cannot guess what this button means.

Suggesting

For low-hanging fruit, I think it's okay to move the button title to its label. It could be ugly, but easy to guess.

Button named "Back to style manager"

-          <button id="cancel-button" i18n="title:styleCancelEditLabel">↩</button>
+          <button id="cancel-button" i18n="styleCancelEditLabel"></button>

or

-          <button id="cancel-button" i18n="title:styleCancelEditLabel">↩</button>
+          <a id="cancel-button" href="./manage.html" i18n="styleCancelEditLabel"></a>

(Disclaimer: I didn't build and check this)

tophf commented

You can make a user style:

@-moz-document regexp("^\\w+-extension://[^/]+/edit.*") {
  #cancel-button {
    font-size: 0;
    &::after {
      font-size: 13px;
      content: attr(title);
    }
  }
}
xnuk commented

Could you tell me in detail? Will everything be rejected if it could be fixed by writing user style themselves?

tophf commented

There's no evidence that this change is necessary to people in general, so indeed such suggestions will be rejected.

  • 😕1