openstyles/stylus

Can't publish to userstyles.world in Vivaldi

mmccul opened this issue · 5 comments

Bug Report

Bug Description

Referenced line:

redirect_uri: 'https://gusted.xyz/callback_helper/',

Created a style some time ago, published it to userstyles.world without issue. Some time later, the computer that did that publication is replaced. Download the styles I've worked on, and made a trivial update based on feedback I received, then tried to publish it. I was able to authenticate to userstyles.world then select the style I wished to link to.

At that point, a pop-up window is created with a code=... content of what appears to be web token of some kind. Nothing I can do with that token. Nowhere to place it. If I close the pop-up window, then Stylus deems my attempt to publish to be user cancelled.

The URL that shows the token is gusted.xyz and is the base URL at the above referenced line.

Screenshots

N/A

CSS Code

N/A

System Information

  • OS: Windows 10
  • Browser: 6.7.3329.26 (Stable channel) (64-bit)
  • Stylus Version: 1.5.46

Additional Context

Sounds like a bug in Vivaldi. We added workarounds for similar bugs, so apparently they broke something again. We'll have to switch to chrome.identity API in ManifestV3 so it might fix this problem as well. Meanwhile try clearing cookies for userstyles.world, disconnect the style, then reconnect it again.

confirm

IIRC, we should use tabs instead of popups for authentication on Vivaldi. @tophf Is that still true? I guess the code of browser detection is outdated.

Also I ran the STR from #1182 and it is still bugged.

Windows 10
Vivaldi 6.8.3381.46 (Stable channel) (64-bit)

Vivaldi has removed its augmentation from the tab object, so apparently there's no way to detect it now. As I mentioned above, we'll have to use chrome.identity API anyway, which will hopefully behave correctly in Vivaldi.

It's moved to a chrome.windows object now.