Enhance release.js tests to calling github API
kislerdm opened this issue · 0 comments
kislerdm commented
Problem
The test release.js mocks HTTP calls to github API wrongly. It led to testing side effects and unnecessarily quota consumption, see example.
Proposed Solution
Fix the "unhappy path" tests relying on the mock function fetchReleases
As a nit, nock can be removed from dependencies because it's not used.