opentracing-contrib/java-jaxrs

String comparison using equals

jasondlee opened this issue · 7 comments

I could be missing something subtle, but this looks like a bug (String comparison using == instead of .equals() ).

if (m.getName() == method.getName() && Arrays.deepEquals(m.getParameterTypes(), method.getParameterTypes())) {

I could be missing something subtle, but this looks like a bug (String comparison using == instead of .equals() ).

if (m.getName() == method.getName() && Arrays.deepEquals(m.getParameterTypes(), method.getParameterTypes())) {

what if m.getName is Null. [.equals] will throw a NPE .

would you like to submit a fix?

would you like to submit a fix?

Can you please assign to me?

@pavolloffay Can u provide me access.
i am getting below error while pusing.
remote: Permission to opentracing-contrib/java-jaxrs.git denied to rishi-lgtm. fatal: unable to access 'https://github.com/opentracing-contrib/java-jaxrs.git/': The requested URL returned error: 403

The repository is public you should be able to fork it and submit a PR from your fork.

Have raised a PR
#146

Done in #146