opentracing-contrib/nginx-opentracing

Question: Any chance to update opentracing-cpp to 1.6.0?

aledbf opened this issue · 5 comments

Question: Any chance to update opentracing-cpp to 1.6.0?
miry commented

@aledbf pls check this PR: #143

The current implementation is working fine with Opentracing 1.6.0.

miry commented

@aledbf I would ask your opinion about opentracing-cpp v1.6.0.
Currently only Jaeger CPP supports Opentracing v1.6.0.
And there are some PR in Jaeger that would support W3C format.

Do you think it is ok to stop support other traces (in ingress-nginx as well)?

Do you think it is ok to stop support other traces (in ingress-nginx as well)?

Not really. That would be a breaking change for lots of users.
One of the implementors - datadog is waiting for this update to release a compatible version?
DataDog/dd-opentracing-cpp#115 (comment)

miry commented

@aledbf Did I understand correctly.dd-opentracing-cpp is compatible with Opentracing-cpp 1.6.0 ?

Need to recheck other traces, may be they also ready for upgrade.

For nginx-opentracing there are no changes required to support opentracing-cpp 1.6.0.
I was blocked only by traces.

miry commented

@aledbf Released a new version of nginx-opentracing. Now it releases modules for Opentracing 1.5.1 and Opentracing 1.6 https://github.com/opentracing-contrib/nginx-opentracing/releases/tag/v0.14.0

The docker image uses Opentracing v1.6.0