Type hinting

Question

Type hinting

piotrooo opened this issue 6 years ago · 5 comments

piotrooo commented 6 years ago

Hi,
now we have on our master branch PHP >= 7.1, maybe next step is use type hinting?

I have been done with some changes, almost all classes covered that changes. What do you think about it?

Answer 1 · 2019-04-11T10:33:18.000Z

I think this is the next natural step. A PR for this is welcome.

Answer 2 · 2019-04-11T20:25:57.000Z

@jcchavezs Consider to create a tag before merging to upstream

Answer 3 · 2020-04-20T05:24:22.000Z

A friendly reminder, this is a breaking change.

Answer 4 · 2020-04-20T09:03:31.000Z

Hi @Reasno, truth is PHP 5.6 is long deprecated and we are moving the compatibility to PHP 7.2 to take advantages of typing in PHP and reduce the boiler plate in implementations.

Answer 5 · 2020-04-20T10:47:59.000Z

Hi @Reasno, truth is PHP 5.6 is long deprecated and we are moving the compatibility to PHP 7.2 to take advantages of typing in PHP and reduce the boiler plate in implementations.

I am looking forward to it. Hope OT implemetations can keep up the pace.