opentracing/opentracing-python

Scope not closed during tests

Closed this issue · 3 comments

mihau commented

scope = tracer.start_active_span('Fry')

In this test a scope is being opened, but it's left unclosed. This might cause issues, since an active scope will persist in thread local storage even though a new tracer is created, causing another test to fail.

This can be treated as an issue with tests, or a broader one - the key for active scope in thread local storage being same for all tracers created in that thread.

Fixed by #97

@mihau #97 was merged last August, but this ticket opened 12 days ago? I'm confused.

mihau commented

Sorry for that, I forgot about the fix , and used 2.0.0 by mistake, my bad. Closing