openwallet-foundation/credo-ts

Incompatibility with Lissi OOB URLs

Closed this issue · 1 comments

I've recently trying out Lissi demo to see how far an AFJ-based app can go and I noticed that in their invitation URLs they are using oob query parameter and encoding a connections/1.0/invitation message into it. AFJ expects it to be an out-of-band/1.x/invitation message, so as a result it throws a validation error when scanning the code.

Whilst I think AFJ interpretation is correct, based on the wording from Aries RFC 0434 where it says The oob query parameter is required and is reserved to contain the out-of-band message string one could also interpret that 'out-of-band' refers to any DIDComm message that will be send out of band (i.e not strictly from the out-of-band protocol).

So in some way I don't see that it would be harmful to allow processing a former connections protocol invitation encoded in oob query parameter. What do you think?

Yeah makes sense! No harm in supporting it I think