openwisp/django-loci

[ci] Add CI check for migrations

marfgold1 opened this issue ยท 6 comments

Add CI check for migrations with this solution for ensuring the migrations created have have been renamed to something more descriptive like this GCI task says.

Hello @atb00ker @nemesisdesign !
I want to ask about this issue.
In the runcheckmigration file in the solution provided, i found this line:

checkmigrations --migrations-to-ignore 2 \
			   --migration-path ./tests/testapp/migrations/ || exit 1

I did observe a little bit, and found out that django-loci does not have ./tests/testapp/migrations/ path in it. Should i remove that line or what?
And last, this line:

checkmigrations --migrations-to-ignore 3 \
			   --migration-path ./openwisp_users/migrations/ || exit 1

Should i replace openwisp_users to django_loci?
Thank you very much :)

Try to take a look at what I did and try to understand...

openwisp/django-ipam#57

@marfgold1 those lines are for that repository, for this repository you will obviously need and test if everything is working here. ๐Ÿ˜„
Remember: Don't copy the lines, make them work on your system and ensure that it's correct, that example in the task is just for reference. ๐Ÿ˜„

Yeah i already pull request and commit about it, would you like to review my PR @atb00ker ? Thanks

There is already a review! Please check it. ๐Ÿ˜„

There is already a review! Please check it. ๐Ÿ˜„

Done ๐Ÿ‘. Please review it again @atb00ker ๐Ÿ˜†, thanks ๐Ÿ˜„