openwisp/openwisp-radius

[bug] FreeRADIUS PostAuthView returns 500 error

pandafy opened this issue · 8 comments

pandafy commented

The FreeRADIUS PostAuthView (/api/v1/freeradius/postauth/) returns HTTP 500 error if the length of called_station_id field exceeds 50 characters.

A possible fix could be to update the PostAuthSerializer and set max_length attribute on the called_station_id field. This way, the view would return HTTP 400 with the error reason.

ujjwalkirti commented

@pandafy I want to work on this issue, can you assign this issue to me?

pandafy commented

@ujjwalkirti you can start working on this issue. You don't need to wait for someone to assign this issue to you, just an intent message is enough. 😄

I would recommend you to start by writing a failing test case before updating the serializer.

I would also recommend you to join the OpenWISP development chat.

nick2432 commented

can i start working on this?

pandafy commented

Yes @nick2432, go ahead! Don't forget to read my previous comments.

sumiran18 commented

I want to work on this issue , can you pls assign me this ?

nemesifier commented

Welcome @sumiran18! Create a PR first, then I'll assign it to you.

sanjeevholla26 commented

Can I work on this issue?