Update 0.9.x to use grpc-google-cloud-trace-v1

Question

Update 0.9.x to use grpc-google-cloud-trace-v1

saturnism opened this issue 6 years ago · 5 comments

Zipkin GCP 0.10.x is using grpc-google-cloud-trace-v2 Stackdriver Trace v2 API is not yet GA.
Zipkin GCP 0.9.0 is using devtools which is deprecated and pulls in old dependencies. It would be great to update a 0.9.x version that continues to use v1 API but w/ newer dependencies.

Answer 1 · 2019-02-20T21:09:14.000Z

/cc @adriancole not sure how you feel about having an version alternative that uses Stackdriver Trace V1 API.

Answer 2 · 2019-02-20T23:19:39.000Z

I think my higher concern is maintaining a release branch.. we dont do that generally.. is it possible for these to coexist (package names different)?

Answer 3 · 2019-02-21T03:53:13.000Z

package names are in fact different. it's possible to have both StackdriverSenders

Answer 4 · 2019-02-21T05:16:03.000Z

I suspect it would be a V1 encoder if we did it this way.. https://github.com/openzipkin/zipkin-gcp/blob/master/sender-stackdriver/src/main/java/zipkin2/reporter/stackdriver/StackdriverEncoder.java

…

On Thu, Feb 21, 2019, 11:53 AM Ray Tsang ***@***.***> wrote: package names are in fact different. it's possible to have both StackdriverSenders — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#116 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD6195kILCkDZpnn_Pyb_w3PAUHOgdIks5vPhgpgaJpZM4bF76w> .

Answer 5 · 2019-08-05T19:59:18.000Z

chatted w/ @meltsufin; we think we can put this on hold for now. will re-open if situation changes.