operate-first/common

Don't fix teams during dry run time

Closed this issue · 12 comments

When adding new teams we see ci failures: #62

This is probably due to

--fix-team-members \

which we shouldn't be doing during a dry run.

@HumairAK @harshad16 do you want to keep #62 open for debugging?

no, we will open a separate pr to fix this.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

/remove-lifecycle stale

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@HumairAK has this been anymore cases involving this? I found this issue in peribolos which seems to be related, however seeing as I can't check the logs for the failed test I cant verify. Weather this is due to the ci-prow bucket overflowing OBCs incedent or simply because the logs have expired I am getting a 504. I am happy to make this change regardless in a PR I just want to see if you have seen any examples of this since, or if this issue has not reoccured yet.
/remove-lifecycle stale

@Gregory-Pereira an easy way to tell would be to emulate a test pr where a team is being added and see if the ci fails

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.