Include final digit in prerelease API versions
joshgav opened this issue · 2 comments
Standard Kubernetes prerelease API versions (at https://github.com/kubernetes/api) include a number after the alpha or beta keyword, e.g. v1alpha1, v1alpha2, v1beta1, etc.
But this hybrid plugin and the Quarkus/Java one leave off the final digit of the version, as in the following paths. Could you please add a final number in the future for consistency with other K8s APIs and to prevent hard-to-notice bugs? Thanks!
Looks like this may go back to kubebuilder, which provides a limited enum for Stage, see https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/model/stage/stage.go
Yeah, this is inherited from Kubebuilder. It's been a loooooong time but I remember there being a discussion about it when we were working on the Kubebuilder phase 1 plugin design. It is totally unrelated to the Kubernetes API concept, so there's no technical need to align, but I can see how it might be jarring. Apologies, but I can't remember the reasoning behind this choice.
Closing since we inherit from kubebuilder and there isn't much we can do here.