operator-framework/helm-operator-plugins

Update for kubebuilder v3

joelanford opened this issue · 3 comments

joelanford commented

See operator-framework/operator-sdk#4402

I don't necessarily agree with all the changes in the above PR (e.g. I'm not sure the Helm plugin should depend on the Go plugin), so let's see if we can port these changes over and resolve any issues like this.

camilamacedo86 commented

hi @joelanford,

Helm/Ansible as any other plugin should not depend on golang one. The problem is that we needed to align SDK with KB. It has not been done for too long. See that this pr has more than 220+ files and was something very complex to be achieved.

Also, you will find out todo's in the code to replace the golang.options by the resource func new and validate when them one exists in KB. Note in all places but you will.

See my comments here: operator-framework/operator-sdk#4584 (comment)

joelanford commented

Makes sense! I figured there was a good reason. I managed to use resource.Resource in the PR that closed this issue. If you have a chance, could you double check that and let me know if I overlooked something?

camilamacedo86 commented

I should probably add a comment in all places to not bring this misunderstanding. The follow up is never soon followed as we wish :-)

By giving a fast look at the pr all show fine. However, imo the best way to check that is by diff the templates dir with sdk and push the changes via IDE. I understand that the plugins/helm should be == here.

I will try to do that and let you know.