opstic/gdclone

Panic on X11 due to icon size

oatmealine opened this issue · 2 comments

On Linux X11, starting the game fails due to the icon size (assets/branding/icon.png)

2023-07-20T04:30:42.813272Z  INFO bevy_winit::system: Creating new window "GDClone" (0v0)
2023-07-20T04:30:42.813407Z  INFO winit::platform_impl::platform::x11::window: Guessed window scale factor: 1
2023-07-20T04:30:42.842178Z  INFO gdclone::discord: Initializing Discord integration...
2023-07-20T04:30:42.842337Z  INFO gdclone::discord: Waiting for Discord handshake...
2023-07-20T04:30:42.890577Z  INFO bevy_render::renderer: AdapterInfo { name: "AMD Radeon RX 560 Series", vendor: 4098, device: 26607, device_type: DiscreteGpu, driver: "AMD open-source driver", driver_info: "2023.Q2.3 (LLPC)", backend: Vulkan }
2023-07-20T04:30:42.952812Z ERROR winit::platform_impl::platform: X11 error: XError {
    description: "BadLength (poly request too large or internal Xlib length error)",
    error_code: 16,
    request_code: 18,
    minor_code: 0,
}
thread 'main' panicked at 'Failed to set icons: XError { description: "BadLength (poly request too large or internal Xlib length error)", error_code: 16, request_code: 18, minor_code: 0 }', /home/oatmealine/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.28.6/src/platform_impl/linux/x11/window.rs:1008:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Encountered a panic in system `gdclone::setup`!
Encountered a panic in system `bevy_app::main_schedule::Main::run_main`!

Resizing the image to 128x128 and retrying seems to avoid this:

2023-07-20T04:32:06.890984Z  INFO bevy_winit::system: Creating new window "GDClone" (0v0)
2023-07-20T04:32:06.906202Z  INFO winit::platform_impl::platform::x11::window: Guessed window scale factor: 1
2023-07-20T04:32:07.117290Z  INFO gdclone::discord: Initializing Discord integration...
2023-07-20T04:32:07.117422Z  INFO gdclone::discord: Waiting for Discord handshake...
2023-07-20T04:32:07.243918Z  INFO bevy_render::renderer: AdapterInfo { name: "AMD Radeon RX 560 Series", vendor: 4098, device: 26607, device_type: DiscreteGpu, driver: "AMD open-source driver", driver_info: "2023.Q2.3 (LLPC)", backend: Vulkan }
2023-07-20T04:32:07.320909Z  INFO gdclone::loader::gdlevel: Loading save
2023-07-20T04:32:07.764659Z  INFO gdclone::discord: Successfully connected to Discord

...
opstic commented

@oatmealine I have just pushed a commit that will use a small version of the icon instead.

As it is resized to 256x256px, twice as large as the resolution you tested, could you test it again, if possible?

Works fine now, ty