opticdev/optic

Requests run command is run in a new window on windows.

juliangrube1988 opened this issue · 5 comments

juliangrube1988 commented

Describe the bug
The specified command from requests/run/command in optic.yml is run in a new Window. If the command fails users cant see the output.

To Reproduce
Steps to reproduce the behavior on Windows:

  1. add nx run foo to optic.yml requests/run/command
  2. run optic capture
  3. new window opens

Expected behavior
Everything is printed to the same terminal just like on a linux machine. The opening of a new window might be due to:
NodeJs > process > spawn > windowsHide (is not set).

Details (please complete the following information):

  • Windows 11
  • Optic: 0.49.3
  • NodeJS version: 18.14.0
acunniffe commented

Hey @juliangrube1988 I've opened #2260 that makes the change you suggested. It seems to have worked on my Windows 10 VM, but I haven't tested in on Windows 11 yet.

Can you give it a try? It's in a prerelase of Optic 0.49.4-0

npm install -g @useoptic/optic@0.49.4-0

Legiew commented

Hey, we tested the new version, but the changes in the last version didn't change the reported behaviour.
I had a detailed look and tried out to set in runRequestsCommand the detached property of the spawn call to false. That solved all the issues in combination with windowsHide: true.
Why is the detached property set to true? Optic waits for the command to finish, so there is no way, that the command runs longer than optic itself right? Or did I miss something?

acunniffe commented

Some of our tests aren't passing when we have detached:false -- can you share more information about your shell? Is it WSL? Powershell? So we can do a better reproduction

juliangrube1988 commented