optimizely/csharp-sdk

EventTagUtils.GetNumericValue() incorrectly logs an error when no value key is present

jwilke opened this issue · 2 comments

jwilke commented

My organization is in the process of upgrading clients and have started seeing this error:

The numeric metric key is not in event tags.

After some investigation, we have traced it down to this function call

csharp-sdk/OptimizelySDK/Event/Builder/EventBuilder.cs

Line 219 in 466feef

var eventVallue = EventTagUtils.GetNumericValue(eventTags, Logger);

Contrast EventTagUtils.GetNumericValue() to EventTagUtils.GetRevenueValue(). Notice that when the revenue key is not present in the event tags, it logs as a debug. I assume the same pattern should be applied to GetNumericValue()

My organization is working around this by simply adding "value":0, to our event tags for now since error level logs will cause issues in our production system.

mikeproeng37 commented

Thanks! We will look into this.