optimizely/javascript-sdk

Typescript Types for Browser Client

arjansingh opened this issue · 3 comments

How would the enhancement work?

We typed out a bunch of the client side definitions for a Typescript product we were working on. I was wondering where we could contribute them back?

Here's the gist:
https://gist.github.com/pwfisher/e550c8a58b052c12dd503a6f30eb8bc4

When would the enhancement be useful?

They would provide type definitions for anyone working in a strict Typescript environment.

I thought this repo was already typed node_modules/@optimizely/optimizely-sdk/dist/shared_types.d.ts

Correct @Develliot we provide a the d.ts type definitions in the published npm package release

@arjansingh, if there's something we've missed in the release delivery, ping back here and let us know....but thanks for thinking to contribute back upstream. Cheers.

I don't even remember filing this. 😂