optimizely/php-sdk

phpdoc on addNotificationListener incorrect

mcfunley opened this issue · 2 comments

mcfunley commented

$notification_callback is documented as a string, but it should be callable. This causes problems for people using static analyzers (such as https://github.com/phan/phan) that try to enforce this.

php-sdk/src/Optimizely/Notification/NotificationCenter.php

Line 62 in 3280346

* @param string $notification_callback A valid PHP callback

mikeproeng37 commented

Thanks for submitting, we will take a look.

aliabbasrizvi commented

This was fixed in release 2.2.1: https://github.com/optimizely/php-sdk/blob/master/CHANGELOG.md#221

Thanks for reporting @mcfunley. Going to close this issue.