oqtane/oqtane.framework

[ENH] Return URL for ModuleActions -> Settings should contain URL parameters

Closed this issue · 5 comments

mdmontesinos commented

Oqtane Info

Version - 5.2.2
Render Mode - Static
Interactivity - Server
Database - SQL Server

Describe the enhancement

Currently, if you go into Edit Mode and access the settings when in a page with url parameters, the return url does not contain the parameters, so it's a great inconvenience for content managers.

For example, if I am in a page "news/!/the-latest-news" and I enter the module settings (Edit Mode -> Module Actions -> Settings), after saving or cancelling, I will be returned to "news?edit=true". This is really annoying when editing many pages, as perhaps the setting I changed only can be visualized when the page has that parameter. In that case, I need to again navigate back to parametrized page.

Therefore, the return url should also contain the page parameters and query.

mdmontesinos commented

@sbwalker Thanks, it's working as expected!

mdmontesinos commented

@sbwalker This should actually be applied for all module actions, as trying to move, unpublish, delete, etc, also results in losing the page url parameters.

sbwalker commented

@mdmontesinos #4640 fixes this for all module actions

mdmontesinos commented

@sbwalker It's working fine, but several parameters are being duplicated in the url:

?edit=false&refresh=true&edit=true&refresh

sbwalker commented

@mdmontesinos I know why that is happening... I will resolve today