The get-alphas-fn in ClojureScript should wrap the fact-type-fn and ancestors-fn

Question

The get-alphas-fn in ClojureScript should wrap the fact-type-fn and ancestors-fn

Closed this issue 7 years ago · 5 comments

The fact-type-fn is currently wrapped to detect system types in the Clojure implementation [1] but no such wrapping exists in the ClojureScript implementation [2, 3]. This could cause the fix for #149 to break in ClojureScript if a custom fact-type-fn is used. The ClojureScript implementation should also use the wrapped version on the ancestors-fn that I anticipate will be added to resolve #236 for reasons discussed there that are the same in Clojure and ClojureScript.

Answer 1 · 2017-02-23T14:46:40.000Z

I think link one is supposed to be https://github.com/cerner/clara-rules/blob/master/src/main/clojure/clara/rules/compiler.clj#L1515

Answer 2 · 2017-02-23T15:44:50.000Z

@Zylox agreed; I've updated the original post with a link to the same tag as previously.

Answer 3 · 2017-05-11T21:28:35.000Z

I've started working on this.

Answer 4 · 2017-05-11T22:27:53.000Z

I have submitted a PR to fix this at #295

Answer 5 · 2017-05-17T17:26:00.000Z

#295 fixed this issue and has been merged. Closing.