Inconsistent naming on Fact Type Customization example
Closed this issue · 1 comments
The last example given at Fact Type Customization is a bit confusing because of that.
At the last paragraph:
Clara will then call the ancestors-fn with an argument of :precise-temperature-fn.
should be
Clara will then call the ancestors-fn with an argument of :precise-temperature-reading.
, and
In this case, since :temperature-reading is in the set of ancestors of :precise-temperatures-fn it is considered…
should be
In this case, since :temperature-reading is in the set of ancestors of :precise-temperatures-reading it is considered…
@felipe-campos Thanks for pointing that out. I pushed oracle-samples/clara-site@36e8fd9 to fix this.
I'm going to go ahead and close this since the change seems straightforward, but feel free to reopen if I made a mistake in the fix or there is more to discuss about it.