oracle-terraform-modules/terraform-oci-oke

Allow for node pool specific max_pods_per_node

tcrowder-koerber opened this issue · 0 comments

tcrowder-koerber commented

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The setting max_pods_per_node is currently a global variable and should be scoped down to each node pool.

New or Affected Resource(s)

VPC-native networking

Potential Terraform Configuration

# bad
worker_pools = {
    azdo-build-agents-cpu= {
      allow_autoscaler = true,
      max_pods_per_node = var.max_pods_per_node
      cni_type         = "npn" 
    },
    azdo-build-agents-ram = {
      allow_autoscaler = true,
      max_pods_per_node =  var.max_pods_per_node
      cni_type         = "npn" 
    }
  }
  # ok
  worker_pools = {
    azdo-build-agents-cpu= {
      allow_autoscaler = true,
      max_pods_per_node = 4
      cni_type         = "npn"
    },
    azdo-build-agents-ram = {
      allow_autoscaler = true,
      max_pods_per_node = 16
      cni_type         = "npn" 
    }
  }

References