oracle/weblogic-deploy-tooling

Add warning message for username/password

gregoan opened this issue · 8 comments

gregoan commented

Hello,

The username and group defined in default authenticator are not exported by WDT.
This is not a real blocking point but will it be possible to add warning message in generated model file

The username/password are not exported so please check if they exist and add them in model file if needed

or to make this warning message customizable from command line property in case others customers don't want to see it ?

Regards.

robertpatrick commented

Discover Domain is not able to export the users and groups defined in the Default Authenticator. We will consider a configurable warning message as a potential enhancement request.

gregoan commented

Thanks a lot for this

robertpatrick commented

@gregoan Having thought a little about this, the concern that I have is that this warning would always appear for every single run of the Discover Domain tool. It's not like there is some domain characteristic we could use to determine whether to do this warning since every domain has at least one authentication provider.

Given that a warning will cause the discoverDomain shell script to exit with an exit code of 1 (denoting that there was one or more warning). We could make this a notification level log message and this will still cause it to show up in the tool summary without forcing a non-zero exit code.

If the message always appears, it's not clear that it is better to create the message or just document the limitation (assuming it isn't already). In my experience, if something happens all the time, people tend to ignore it.

Thoughts?

gregoan commented

Hi,

Today, I execute :
${HOME}/weblogic-deploy/bin/discoverDomain.sh -oracle_home ${oracleHome} -model_file ./DomainModel.yaml -variable_file ./DomainVariable.properties -admin_url ${oracleServerUrl} -remote -skip_archive

Tomorrow, I would like to know if it's possible to execute something like this (-print-warning is added - it's an example):
${HOME}/weblogic-deploy/bin/discoverDomain.sh -oracle_home ${oracleHome} -model_file ./DomainModel.yaml -variable_file ./DomainVariable.properties -admin_url ${oracleServerUrl} -remote -skip_archive -print-warning

  • The default mode for print-warning is false
  • If it's not set, we are using the current behavior.
  • If it is set then a header message could be added inside generated file (or an INFO message on STODUT) informing the user none username/group will be generated meaning an additional and manual check must be executed.
  • The warning/info message is not interfering with shell script execution (return code)

What do you think ?

robertpatrick commented

@gregoan Sorry, I must not have communicated my concern clearly. Let me try again.

Since the message will appear on every invocation (when you enable it), I am concerned that we are just adding information that the user will learn to ignore (since it happens every time). Why do we need to log a message about this with every Discover Domain execution rather than just documenting the limitation; for example, on https://oracle.github.io/weblogic-deploy-tooling/userguide/limitations/limitations/?

gregoan commented

@robertpatrick I see and you are totally right :)
I knew the limitation because I read the doc but it's not the case of everybody :)
I agree with your proposal ; let's try for it

gregoan commented

It's good from my point of view