bower install looks for scrollreveal 0.1.2
Closed this issue · 3 comments
That version isn't there. There's only 2.0.2, 2.0.1 and 2.0.0 available
I was doing the upgrade but that version broke a very important feature here.
You can't call init()
in this new version. That way, if you add new elements through, for example, ng-repeat
, those elements would not have reveal's capabilities, as the setup is done inside init()
. I just created an issue there and am waiting to see what Julian says.
In my tests, letting users call init()
more than once didn't break anything, so I hope we can solve this.
this one jlmakes/scrollreveal#98 ? I created a directive based on offset alone https://github.com/caioiglesias/scroll-animate-directive no viewport calculation at all.
Yeah Caio that commit right there. I worked with Julian to fix the bug and was waiting for him to make a release. In the meantime I just got full of work and didn't have time to update this directive.
Now it is fixed, I bumped the version to 1.0.0 as scrollReveal itself is not a 0.x release anymore and I think everything is running OK.
Your directive is really useful but it lacks the fine tuning that scrollReveal's has. If you wanted individual animations or even random, as I use in my project, yours is not going to work.