Wrong building table used by grid indicators ?
Closed this issue · 6 comments
It seems the grid indicator calculation is using buildings without the estimated height... It has to be checked. Might be a cache issue ?
OK, indeed there is a major bug in the OSM workflow. The building table containing the updated height is not used by the grid indicator nor the the noise indicator !!
@ebocher I update the code and you validate ?
I wonder whether it would also be an opportunity to move some parts of the OSM workflow into a more generic functions (in the workflow indicator) instead of having to maintain OSM and BDT workflows. This is particularly the case for the future: if we have a script which makes the indicator calculation for any input data it would be easier if everything is generic (outside the data related workflows).
OK, indeed there is a major bug in the OSM workflow. The building table containing the updated height is not used by the grid indicator nor the the noise indicator !!
In the osm_processing() in the WorkflowOSM.groovy file, the "buildingTableName" variable is sometimes used while it is updated within the code if the building height estimation is used. Thus "results.building" should be used instead (as it is the case in the "buildingPopulation" function).
@MelPoupelin do not use the grid indicators as long as this problem is not solved
A mistake certainly due to the numerous reorganizations of the code in recent weeks.
I suggest fixing the table building problem first, before starting a major restructuring that may cause new problems.
I will send a PR to fix that. You've just rescued GeoClimate ;-)