Do we really need to compile the tests?

Question

Do we really need to compile the tests?

Closed this issue a year ago · 6 comments

Would it be possible to avoid compiling/running the tests? They are really expensive time-wise.

Answer 1 · 2022-12-29T15:00:10.000Z

I noticed that too. CMake seems to run diff-match-patch's CMake build too. There's probably a way to avoid it completely since only the header file is needed for this module.

Answer 2 · 2022-12-30T08:53:58.000Z

Hi, I went back to the sources of diff-match-patch and found out that they have a Lua version. Currently fiddling around a bit with it to see if a pure Lua version is feasible (which I think it is) This would greatly alliviate the situation and Win1x and macOS. My current Win1x (yes, I know... I would rather not have to be on it) started complaining about the distributed diff.dll

…

On Thu, 29 Dec 2022 at 16:00, orbitalquark ***@***.***> wrote: I noticed that too. CMake seems to run diff-match-patch's CMake build too. There's probably a way to avoid it completely since only the header file is needed for this module. — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZKU4EO63MPKIY2DZETC33WPWRQLANCNFSM6AAAAAATL35INU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler Headaches with a Juju log: unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run a leader-deposed hook here, but we can't yet

Answer 3 · 2022-12-30T15:34:20.000Z

Originally I used the pure Lua version, but it was **really** slow, so I had to fall back on the C++ version. Obviously that hurts from a portability perspective :(

Answer 4 · 2022-12-30T15:56:04.000Z

I'm dumb. I initially realized this, but I forgot that I updated the GitHub Actions build script to only build for the "diff" target: `cmake --build build --config Release --target diff -j`. That will only build the module. From the build directory you should also just be able to run `make diff` if you're using CMake's Makefile generator.

Answer 5 · 2022-12-30T17:56:47.000Z

OK, anyhow I made it... just to make sure that I can use it without having the OS complaining.
Take a look in my GitHub ;-) seems to work and, BTW, doesn't look that slow on files the size I normally use.
These include the Textadept12 theme generator in Theme Creator (already in my GitHub too)

Happy New Year

Answer 6 · 2024-09-28T16:57:54.000Z

Closing because I think this is either fixed or can be avoided with proper tooling (e.g. cmake --build build_dir --target diff, make diff, etc.).