Sane handling of non-bin and non-lib crates
appetrosyan opened this issue · 1 comments
appetrosyan commented
I understand that this action has the dubious convenience of parsing the manifest and adding all the packages that cargo bloat
wouldn't into the list of packages to process. This is an acceptable (if inefficient) method, but it has a few problems.
Normally, cargo bloat
ignores the projects that it can't work with. The action fails and stops.
Normally you can manually specify the packages (or binaries) for which we need to test for bloat. In this action I have to specify every workspace in the package (which normally outnumber the libraries). Moreover, the syntax is not explained. I expected a sequence to be an acceptable input.
Solution
- Don't fail fast on crates that are not supported. Just skip them
- Don't try to outsmart
cargo bloat
. - Instead of specifying the
exclude crates
specify included packages.