orf/gping

cannot resolve error when attempting to ping an IPv6 address

artooro opened this issue · 5 comments

I'm fairly sure this was working before, it appears a recent version of gping broke the ability to ping IPv6 addresses.

For example running the command:

gping 2001:db8::1

It responds with the error:

There was an error running ping: exit status: 68
                                                Stderr: ping: cannot resolve 2001:db8::1: Unknown host

I'm running version 1.6.3

gping 1.6.3
commit_hash: 
build_time: 2022-12-20 21:21:34 +00:00
build_env: rustc 1.65.0,
orf commented

Hey, what OS are you using? Can you run ping --version for me?

@orf running on macOS 13.1
Maybe it's macOS that changed and not gping?

I'm not sure what the version flag would be, --version doesn't exist

ping: unrecognized option `--version'
usage: ping [-AaDdfnoQqRrv] [-c count] [-G sweepmaxsize]
            [-g sweepminsize] [-h sweepincrsize] [-i wait]
            [-l preload] [-M mask | time] [-m ttl] [-p pattern]
            [-S src_addr] [-s packetsize] [-t timeout][-W waittime]
            [-z tos] host
       ping [-AaDdfLnoQqRrv] [-c count] [-I iface] [-i wait]
            [-l preload] [-M mask | time] [-m ttl] [-p pattern] [-S src_addr]
            [-s packetsize] [-T ttl] [-t timeout] [-W waittime]
            [-z tos] mcast-group
Apple specific options (to be specified before mcast-group or host like all options)
            -b boundif           # bind the socket to the interface
            -k traffic_class     # set traffic class socket option
            -K net_service_type  # set traffic class socket options
            --apple-connect       # call connect(2) in the socket
            --apple-time          # display current time
orf commented

Hey @artooro - I've pushed a fix to master. Are you able to test this? My internet infuriatingly doesn't have ipv6 yet, so I can't see if it really works.

If you're able to install rust, simply cloning the repo and running cargo run -- 2001:db8::1 should check. Let me know and I'll push a release

Thanks @orf just got a minute to test this today, and it looks like it's working now with gping v1.7.0
Just tested with

gping 1.7.0
commit_hash:
build_time: 2023-01-11 21:21:07 +00:00
build_env: rustc 1.66.1 (90743e729 2023-01-10) (built from a source tarball)
orf commented

Thank you!