Code isn't confident

Question

Code isn't confident

Closed this issue 11 years ago · 3 comments

Fix code per guidelines in Confident Ruby

Answer 1 · 2014-02-16T23:15:06.000Z

This has been partially done in commit 8a2f075; the json readers have been made to explicitly use to_s, to_i etc. as appropriate to ensure the right exception is thrown at the right place.

Answer 2 · 2014-02-18T10:00:49.000Z

Made an error here; using to_i instead of to_int explicitly forces the input instead of just checking if the input is valid and throwing an exception if it isn't.

Answer 3 · 2014-02-18T21:51:52.000Z

More fixes in commit 48d27aa, and I think that's the extent of them. Closing for now...