TooManyRequestsException when changing multiple account tags
castaples opened this issue · 0 comments
Subject of the issue
We tried updating 30ish tags across 15ish accounts and got the 'TooManyRequestsException'
ERROR: failed executing task: Update OC::ORG::Account ************Account TooManyRequestsException: AWS Organizations can't complete your request because another request is already in progress. Try again later.
ERROR: error: TooManyRequestsException, aws-request-id: 06319da4-3257-49a6-9b67-d992760bbf5b
ERROR: AWS Organizations can't complete your request because another request is already in progress. Try again later.
Error: Process completed with exit code 1.
I'm not a TypeScript developer but it looks like this call https://github.com/org-formation/org-formation-cli/blob/master/src/aws-provider/aws-organization-writer.ts#L503 and this call https://github.com/org-formation/org-formation-cli/blob/master/src/aws-provider/aws-organization-writer.ts#L513 should use the same promise 'performAndRetryIfNeeded' as this call https://github.com/org-formation/org-formation-cli/blob/master/src/aws-provider/aws-organization-writer.ts#L522 so that the tag api actions are correctly retried.
Your environment
- version of org-formation: 1.0.6
- version of node: 8.19.2
- which OS/distro: ubuntu-latest (GitHub actions)
Steps to reproduce
Change the tags of lots of account in one go
Expected behaviour
The API (un)tag account calls should retry with backoff
Actual behaviour
You get a TooManyRequestsException