orpatashnik/StyleCLIP

Your latent mapper implementation is weird and possibly wrong

johannwyh opened this issue · 1 comments

As is stated in your paper and also a common practice, the latent mapper should learn a residual of the input code,

w_edit = w_input + M(w_input)

However, the residual step is not implemented in your latent_mapper and styleclip_mappper. And in your trainer, you choose to ignore the forward function of styleclip_mapper and directly access styleclip_mapper.mapper, which is quite weird.

Bumping this as I'm also interested