orthecreedence/carrier

Parses urls incorrectly

fiddlerwoaroof opened this issue · 2 comments

I think this one actually is a bug :)

This code:

(cl-async:with-event-loop ()
  (blackbird:attach (carrier:request "http://api.ipify.org")
                    (lambda (r c h)
                      (format t "~&data: ~a~%code: ~a~%headers: ~s"
                              r c
                              (alexandria:hash-table-alist h)))))

Fails with this result:

data: NIL
code: 400
headers: (("via" . "1.1 vegur") ("connection" . "close") ("date" . "Mon, 29 Aug 2016 19:56:06 GMT") ("server" . "Cowboy"))
0

Using tcpdump, I see that carrier is making this request:

GET NIL HTTP/1.1.
Host: api.ipify.org.

Shouldn't it be defaulting to "/" if the url doesn't have a path part?

Yes, it should default to "/". Good catch!

I think this issue is closed, right?