Toggle switch to show the user's password when on the UserSettingsCard
kevinbtesar opened this issue · 6 comments
Preflight checklist
- I could not find a solution in the existing issues, docs, nor discussions.
- I agree to follow this project's Code of Conduct.
- I have read and am following this repository's Contribution Guidelines.
- This issue affects my Ory Cloud project.
- I have joined the Ory Community Slack.
- I am signed up to the Ory Security Patch Newsletter.
Describe your problem
My feature request is not related to a problem or issue. This request concerns the SettingsFlow. The concern is that once the user has submitted the password reset code, we take them to the UserSetting card within the auth flow. At this point, they can enter their new password. However, there is no way to confirm they have entered their desired value. If an incorrect value is entered, they are forced to go through the password reset process for a second time.
Describe your ideal solution
Our ideal solution is a toggle switch that shows the entered value in the password field as clear text. I'll paste in a mockup our Project Manager and Lead Designer created in Zeplin that illustrates our request.
Workarounds or alternatives
An alternative would be a password confirmation box. I.e., a second password input field that confirms the characters match the value in the first password input field.
Version
v0.0.1-beta.7
Additional Context
I have no additional context at this time.
Thank you
I have been looking into this, please take a look at the draft PR. Suggestions are welcome! :)
@Benehiko That is awesome! Thank you!
I can't try it out right now due to other pressing tasks, but PM will check it out and give me the go-ahead when it's apt for our project. However, I looked over the changes, and they seemed solid.
Thanks again!
Hi @kevinbtesar
I actually found another problem with this implementation when using native form posts (since there are now technically two fields with the same name in the form). I'm busy fixing that quick in a different PR.
@Benehiko That sounds like a plan. No rush. However, I will watch this thread to inform my bosses about your progress.
Do you think the issue/feature request should be reopened until fully addressed?
Sorry about all of the delays, the latest version should now be working :)
@Benehiko No worries at all!
While I can't test it out yet, I looked at your changes, and it seems to be super easy to implement. Many thanks from me, my team, and everyone at Pulsar!!