Add "context" field to the GET login request response if login request for this subject was accepted before and included context

Question

Add "context" field to the GET login request response if login request for this subject was accepted before and included context

Opened this issue a year ago · 2 comments

denysandriyanov commented a year ago

Preflight checklist

I could not find a solution in the existing issues, docs, nor discussions.
I agree to follow this project's Code of Conduct.
I have read and am following this repository's Contribution Guidelines.
I have joined the Ory Community Slack.
I am signed up to the Ory Security Patch Newsletter.

Ory Network Project

Ory Hydra

Describe your problem

When accepting a login request with PUT "/admin/oauth2/auth/requests/login/accept" we are able to set a "context" field.
On the other side, when we are getting a login request with GET "/admin/oauth2/auth/requests/login" and the subject already had login request accepted with context we are able to retrieve the subject from this login request, but not the context that was used while accepting login request.

Describe your ideal solution

If we accept a login request with some context for the subject, this context should also be available if we do a GET "/admin/oauth2/auth/requests/login" for the subject that was already accepted login request

Currently, if login was accepted we are able to retrieve only the subject for which this login was accepted, but the context field is not present in the response.

Workarounds or alternatives

Was thinking of storing the context in Redis or elsewhere but it would be way better and more logical if we store the context of the accepted login inside the login itself, the same way as we currently do with the subject field.

Version

v2.2.0-rc.3

Additional Context

Thank you very much for your consideration

Answer 1 · 2023-09-09T15:48:33.000Z

Hi, any updates on this?

Answer 2 · 2024-09-09T00:05:06.000Z

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

open a PR referencing and resolving the issue;
leave a comment on it and discuss ideas on how you could contribute towards resolving it;
leave a comment and describe in detail why this issue is critical for your use case;
open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️